Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(router): support http.path.segments.* field in expressions flavor #12283

Merged
merged 12 commits into from
Jan 19, 2024
Merged

feat(router): support http.path.segments.* field in expressions flavor #12283

merged 12 commits into from
Jan 19, 2024

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jan 3, 2024 •
edited
Loading

Summary

KAG-3351

Related PR: Kong/atc-router#175

POC PR: #12086

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 3, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 3, 2024
@chronolaw chronolaw marked this pull request as ready for review January 3, 2024 06:28
@chronolaw chronolaw force-pushed the feat/matching_http_segments branch from fb3e637 to 2806fd2 Compare January 5, 2024 02:32
@pull-request-size pull-request-size bot added size/L and removed size/M labels Jan 5, 2024
@chronolaw chronolaw force-pushed the feat/matching_http_segments branch 3 times, most recently from 33ab8f0 to 19bbe0f Compare January 5, 2024 08:56
@chronolaw chronolaw requested review from ADD-SP and dndx January 8, 2024 03:09
ADD-SP
ADD-SP requested changes Jan 9, 2024
View reviewed changes
kong/router/fields.lua Outdated Show resolved Hide resolved
kong/router/fields.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw added this to the 3.6.0 milestone Jan 9, 2024
@chronolaw chronolaw force-pushed the feat/matching_http_segments branch from 3217c0d to 001267a Compare January 12, 2024 08:44
@chronolaw chronolaw force-pushed the feat/matching_http_segments branch 3 times, most recently from 6ff8a65 to 730f40b Compare January 19, 2024 01:54
@chronolaw chronolaw force-pushed the feat/matching_http_segments branch from 730f40b to 2a37723 Compare January 19, 2024 01:56
dndx
dndx requested changes Jan 19, 2024
View reviewed changes
kong/router/fields.lua Outdated Show resolved Hide resolved
kong/router/fields.lua Outdated Show resolved Hide resolved
kong/router/fields.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw force-pushed the feat/matching_http_segments branch from d1b0152 to 865abad Compare January 19, 2024 06:23
@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 19, 2024
@dndx dndx merged commit 9305665 into master Jan 19, 2024
28 checks passed
@dndx dndx deleted the feat/matching_http_segments branch January 19, 2024 06:48
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

chronolaw added a commit that referenced this pull request Jan 23, 2024
@chronolaw
feat(router): support segment based matching in expressions flavor (#…
1e7295f 
…12283)

KAG-3351
@chronolaw chronolaw mentioned this pull request Jan 23, 2024
Merged
3 tasks
@chronolaw chronolaw mentioned this pull request Jan 23, 2024
Merged
3 tasks
chronolaw added a commit that referenced this pull request Jan 24, 2024
@chronolaw
feat(router): support segment based matching in expressions flavor (#…
ce4d6af 
…12283)

KAG-3351
@chronolaw chronolaw mentioned this pull request Jan 24, 2024
Merged
3 tasks
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw
feat(router): support segment based matching in expressions flavor (#…
5851654 
…12283)

KAG-3351
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw
feat(router): support segment based matching in expressions flavor (#…
4f701cc 
…12283)

KAG-3351
chronolaw added a commit that referenced this pull request Mar 4, 2024
@chronolaw
feat(router): support segment based matching in expressions flavor (#…
040d690 
…12283)

KAG-3351
locao pushed a commit that referenced this pull request Mar 5, 2024
@chronolaw @locao
feat(router): support segment based matching in expressions flavor (#…
9ec9665 
…12283)

KAG-3351
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @ADD-SP
feat(router): support segment based matching in expressions flavor (#…
1e75ad0 
…12283)

KAG-3351
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @ADD-SP
feat(router): support segment based matching in expressions flavor (#…
d2d7014 
…12283)

KAG-3351
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@flrgh flrgh flrgh approved these changes

@dndx dndx dndx approved these changes

Assignees

@chronolaw chronolaw

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/db core/router schema-change-noteworthy size/L
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @team-gateway-bot @dndx @flrgh @ADD-SP