-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(timer-ng): bump the minimum/maximum threads #12275
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
2 times, most recently
from
January 2, 2024 09:59
bb777bc
to
ce02927
Compare
github-actions
bot
added
the
chore
Not part of the core functionality of kong, but still needed
label
Jan 3, 2024
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
2 times, most recently
from
January 3, 2024 02:13
a77391f
to
918c433
Compare
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
12 times, most recently
from
January 3, 2024 09:45
f77fca6
to
260bf01
Compare
ADD-SP
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Jan 9, 2024
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
4 times, most recently
from
January 10, 2024 08:40
60bd188
to
2da1e6c
Compare
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
2 times, most recently
from
January 11, 2024 02:12
511f507
to
3f42575
Compare
The internal performance test has passed. |
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
5 times, most recently
from
January 15, 2024 06:54
ed5908d
to
d0ca663
Compare
dndx
approved these changes
Jan 19, 2024
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
from
January 19, 2024 06:54
c1b286c
to
e5ceb4a
Compare
ADD-SP
force-pushed
the
add_sp/perf-bump-cocurrency-of-timer-ng
branch
from
January 19, 2024 06:55
e5ceb4a
to
3f618c8
Compare
chronolaw
approved these changes
Jan 19, 2024
AndyZhang0707
approved these changes
Jan 19, 2024
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12275-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12275-to-master-to-upstream
git checkout -b cherry-pick-12275-to-master-to-upstream
ancref=$(git merge-base 9305665e89f8c83b24c9c3943e83ffaa46b7cb2e 3f618c8ae4f5185ca686dc61a930091936ff25c3)
git cherry-pick -x $ancref..3f618c8ae4f5185ca686dc61a930091936ff25c3 |
@ADD-SP, Please help and take care of the cherry-pick. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
chore
Not part of the core functionality of kong, but still needed
size/M
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please REBASE AND MERGE
Summary
Changes for
timer-ng
.We need to add default concurrency limits to handle some cases where timed tasks proliferate.
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-2932, KAG-3452