Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(router): reuse atc context in router instance #12258

Merged
merged 8 commits into from
Dec 28, 2023
Merged

perf(router): reuse atc context in router instance #12258

merged 8 commits into from
Dec 28, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Dec 27, 2023 •
edited
Loading

Summary

Bump atc-rouer to 1.4.1
See: https://github.com/Kong/atc-router?tab=readme-ov-file#reset

KAG-3448

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

dndx
dndx requested changes Dec 28, 2023
View reviewed changes
kong/router/fields.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw marked this pull request as ready for review December 28, 2023 04:14
dndx
dndx reviewed Dec 28, 2023
View reviewed changes
kong/router/atc.lua Outdated Show resolved Hide resolved
@dndx dndx force-pushed the perf/reuse_atc_context_in_instance branch from f90cf59 to 825e0d3 Compare December 28, 2023 07:43
@dndx dndx force-pushed the perf/reuse_atc_context_in_instance branch from 825e0d3 to 26bc2d9 Compare December 28, 2023 07:53
@dndx dndx merged commit 8c2b5a4 into master Dec 28, 2023
27 checks passed
@dndx dndx deleted the perf/reuse_atc_context_in_instance branch December 28, 2023 08:49
@chronolaw chronolaw mentioned this pull request Jan 2, 2024
Merged
3 tasks
chronolaw added a commit that referenced this pull request Jan 23, 2024
@chronolaw
perf(router): reuse ATC context in router match instead of creating a…
b74504b 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
@chronolaw chronolaw mentioned this pull request Jan 23, 2024
Merged
3 tasks
@chronolaw chronolaw mentioned this pull request Jan 23, 2024
Merged
3 tasks
chronolaw added a commit that referenced this pull request Jan 24, 2024
@chronolaw
perf(router): reuse ATC context in router match instead of creating a…
501db64 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw
perf(router): reuse ATC context in router match instead of creating a…
f30d131 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
chronolaw added a commit that referenced this pull request Feb 26, 2024
@chronolaw
perf(router): reuse ATC context in router match instead of creating a…
49dd49e 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
chronolaw added a commit that referenced this pull request Mar 4, 2024
@chronolaw
perf(router): reuse ATC context in router match instead of creating a…
d04991f 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
locao pushed a commit that referenced this pull request Mar 5, 2024
@chronolaw @locao
perf(router): reuse ATC context in router match instead of creating a…
8bd062a 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @ADD-SP
perf(router): reuse ATC context in router match instead of creating a…
e3acc7e 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
ADD-SP pushed a commit that referenced this pull request Mar 7, 2024
@chronolaw @ADD-SP
perf(router): reuse ATC context in router match instead of creating a…
fc8578b 
… new context (#12258)

To avoid frequent memory allocation/deallocations.

KAG-3448
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ADD-SP ADD-SP ADD-SP approved these changes

@dndx dndx dndx approved these changes

Assignees

@chronolaw chronolaw

Labels
core/router size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @dndx @ADD-SP