-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport release/3.4.x] feat: request debugging #12243
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core/proxy
core/templates
core/configuration
chore
Not part of the core functionality of kong, but still needed
labels
Dec 25, 2023
ADD-SP
force-pushed
the
add_sp/backport-req-dbg-34x
branch
2 times, most recently
from
December 26, 2023 06:19
1ee17e6
to
db989e2
Compare
ADD-SP
force-pushed
the
add_sp/backport-req-dbg-34x
branch
from
December 26, 2023 07:16
db989e2
to
ecdc2c7
Compare
chobits
approved these changes
Dec 28, 2023
ADD-SP
force-pushed
the
add_sp/backport-req-dbg-34x
branch
from
February 19, 2024 03:05
ecdc2c7
to
b55cb63
Compare
KAG-1902 --------- Co-authored-by: Chrono <[email protected]> Co-authored-by: Datong Sun <[email protected]> (origin commit: 3c7b63b)
* tests(request-debug): only initialize DB once in test setup This updates the test setup logic such that helpers.get_db_utils() is only invoked once per test DB strategy. BEFORE: ======= 30 tests from 1 test file ran. (64157.77 ms total) AFTER: ======= 30 tests from 1 test file ran. (52507.36 ms total) * tests(request-debug): truncate error.log before request This updates the tests to truncate the error.log file before making a request that will generate a log entry. The goal is to reduce the overall amount of bytes that must be read from disk and searched through. * tests(request-debug): use line-wise parser for log entries This updates the request debug log entry logic to use `io.lines()` rather than reading the whole file at once. This improves performance and memory usage in the worst-case scenarios of the function. * tests(request-debug): ensure client connection is closed (origin commit: 5f88f20)
…ted config KAG-2808 --------- Co-authored-by: Datong Sun <[email protected]> (origin commit: f0ca42b)
… synchronization with the EE code (origin commit: f59e36b)
(origin commit: 8d10cc0)
ADD-SP
force-pushed
the
add_sp/backport-req-dbg-34x
branch
from
February 27, 2024 01:26
b55cb63
to
b75c4fd
Compare
chronolaw
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Not part of the core functionality of kong, but still needed
core/configuration
core/proxy
core/templates
core/wasm
Everything relevant to [proxy-]wasm
size/XXL
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backports:
request_id
instead ofdebug_id
#11674kong.conf.default
#11779Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
KAG-3440