Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(plugins): refactor tests to address flakiness #12190

Merged
merged 1 commit into from
Dec 12, 2023
Merged

tests(plugins): refactor tests to address flakiness #12190

merged 1 commit into from
Dec 12, 2023

Conversation

gszr
Copy link
Member

@gszr gszr commented Dec 11, 2023 •
edited
Loading

Summary

Refactor ip-restriction test cases to address flakiness; helpers.wait_for_invalidation would hit a different worker than the subsequent proxy request, leading to flakiness in tests. Instead of issuing two requests, one for the Admin and another for the Proxy, wait until the proxy request returns the expected result.

Fix KAG-3207.

@gszr gszr requested review from locao and StarlightIbuki December 11, 2023 17:23
@gszr gszr merged commit 2adad05 into master Dec 12, 2023
30 checks passed
@gszr gszr deleted the fix/ip-restriction-flakiness branch December 12, 2023 10:52
@AndyZhang0707 AndyZhang0707 added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Dec 12, 2023
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-12190-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-12190-to-release/3.2.x
git switch --create backport-12190-to-release/3.2.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12190-to-master-to-upstream' failed with exit code 1

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-12190-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-12190-to-release/3.2.x
git switch --create backport-12190-to-release/3.2.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

2 similar comments
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-12190-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-12190-to-release/3.2.x
git switch --create backport-12190-to-release/3.2.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.2.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.2.x
git worktree add -d .worktree/backport-12190-to-release/3.2.x origin/release/3.2.x
cd .worktree/backport-12190-to-release/3.2.x
git switch --create backport-12190-to-release/3.2.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12190-to-master-to-upstream' failed with exit code 1

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12190-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12190-to-release/3.3.x
git switch --create backport-12190-to-release/3.3.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12190-to-master-to-upstream' failed with exit code 1

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12190-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12190-to-release/3.3.x
git switch --create backport-12190-to-release/3.3.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12190-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12190-to-release/3.4.x
git switch --create backport-12190-to-release/3.4.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12190-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12190-to-release/3.3.x
git switch --create backport-12190-to-release/3.3.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

1 similar comment
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.3.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.3.x
git worktree add -d .worktree/backport-12190-to-release/3.3.x origin/release/3.3.x
cd .worktree/backport-12190-to-release/3.3.x
git switch --create backport-12190-to-release/3.3.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12190-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12190-to-release/3.5.x
git switch --create backport-12190-to-release/3.5.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

'git push --set-upstream upstream cherry-pick-12190-to-master-to-upstream' failed with exit code 1

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12190-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12190-to-release/3.4.x
git switch --create backport-12190-to-release/3.4.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12190-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12190-to-release/3.4.x
git switch --create backport-12190-to-release/3.4.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

1 similar comment
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.4.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.4.x
git worktree add -d .worktree/backport-12190-to-release/3.4.x origin/release/3.4.x
cd .worktree/backport-12190-to-release/3.4.x
git switch --create backport-12190-to-release/3.4.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12190-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12190-to-release/3.5.x
git switch --create backport-12190-to-release/3.5.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

2 similar comments
@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12190-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12190-to-release/3.5.x
git switch --create backport-12190-to-release/3.5.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@team-gateway-bot
Copy link
Collaborator

Backport failed for release/3.5.x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin release/3.5.x
git worktree add -d .worktree/backport-12190-to-release/3.5.x origin/release/3.5.x
cd .worktree/backport-12190-to-release/3.5.x
git switch --create backport-12190-to-release/3.5.x
git cherry-pick -x 2adad05525868d948a16b3ce5953a9846787720f

@gszr
Copy link
Member Author

gszr commented Dec 12, 2023

Manually backported to release/3.5.x - as that is the only branch that shows up in the flakiness dashboard. #12194

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@kikito kikito kikito approved these changes

@locao locao Awaiting requested review from locao

Assignees

@gszr gszr

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gszr @team-gateway-bot @kikito @StarlightIbuki @AndyZhang0707