Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gha): pass version as cloudsmith tags #12175

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

curiositycasualty
Copy link
Contributor

@curiositycasualty curiositycasualty commented Dec 7, 2023

(cherry picked from commit 851ebcf5e65d6ba12aa5026a453e10f978f95ceb)

Summary

This is the sister PRs:

It will allow the version input to the release.yml workflow to be passed as a Cloudsmith tag when uploading packages (assuming it meets the criteria). This will in turn allow us to keep better track of special packages in Cloudsmith, like the recent rc packages.

An existing example of such a tag is the fips tag: https://cloudsmith.io/~kong/packages/?q=tag%3Afips

For this to work, the input must contain: rc,alpha,beta, or nightly
And cannot contain characters outside of: a-zA-Z0-9._,

So an input like "3.0.0.0-rc.3" will work, but an input like "3.0.0.0-gamma.5", "9.9.9.isa%is%cool", or "3.5.0.0+1" will not.

Here's an example of what this looks like on the Cloudsmith side of things (input was 3.6.0.0.rc.0): https://cloudsmith.io/~kong/packages/?q=tag%3A3.6.0.0.rc.0

Checklist

  • [na] The Pull Request has tests
  • [na] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [na] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #KAG-3299

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Dec 7, 2023
@curiositycasualty curiositycasualty force-pushed the build/pass-thru-pkg-tags branch 2 times, most recently from ab14390 to fee5043 Compare December 12, 2023 01:05
(cherry picked from commit 851ebcf5e65d6ba12aa5026a453e10f978f95ceb)
Copy link
Contributor

@RobSerafini RobSerafini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@curiositycasualty curiositycasualty merged commit 1f97197 into master Dec 12, 2023
22 checks passed
@curiositycasualty curiositycasualty deleted the build/pass-thru-pkg-tags branch December 12, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Not part of the core functionality of kong, but still needed size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants