Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(admin_gui): simplify code with table.concat #12092

Merged
merged 1 commit into from
Nov 29, 2023
Merged

refactor(admin_gui): simplify code with table.concat #12092

merged 1 commit into from
Nov 29, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 23, 2023 •
edited
Loading

Summary

simplify code with table.concat

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as ready for review November 23, 2023 23:33
@chronolaw chronolaw requested a review from nekolab November 27, 2023 09:04
nekolab
nekolab approved these changes Nov 29, 2023
View reviewed changes
Copy link
Contributor

@nekolab nekolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the efforts on code simplification! 👍

@windmgc windmgc merged commit 2441e79 into master Nov 29, 2023
34 checks passed
@windmgc windmgc deleted the refactor/simplify_admin_gui_init branch November 29, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@windmgc windmgc windmgc approved these changes

@nekolab nekolab nekolab approved these changes

Assignees

@chronolaw chronolaw

Labels
size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @nekolab @windmgc