Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(templates): bump dns_stale_ttl default to 1 hour #12087

Merged
merged 6 commits into from
Dec 5, 2023
Merged

feat(templates): bump dns_stale_ttl default to 1 hour #12087

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e6aaf25
perf(templates): bump `dns_stale_ttl` default to 1 day
chobits Nov 23, 2023
c62fa58
chore(*): add changelog
chobits Nov 23, 2023
31f6823
Update changelog/unreleased/kong/bump_dns_stale_ttl.yml
chobits Nov 27, 2023
ed4f209
perf(templates): bump `dns_stale_ttl` default to 1 hour
chobits Nov 29, 2023
9be400d
Update kong.conf.default
dndx Dec 5, 2023
75c99df
Update changelog/unreleased/kong/bump_dns_stale_ttl.yml
chobits Dec 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/bump_dns_stale_ttl.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: Bump `dns_stale_ttl` default to 1 hour so stale DNS record can be used for longer time in case of resolver slowness.
chobits marked this conversation as resolved.
Show resolved Hide resolved
type: performance
scope: Configuration
2 changes: 1 addition & 1 deletion kong.conf.default
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1529,7 +1529,7 @@
# property receives a value (in seconds), it
# will override the TTL for all records.

#dns_stale_ttl = 4 # Defines, in seconds, how long a record will
#dns_stale_ttl = 3600 # Defines, in seconds, how long a record will
# remain in cache past its TTL. This value
# will be used while the new DNS record is
# fetched in the background.
Expand Down
2 changes: 1 addition & 1 deletion kong/templates/kong_defaults.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,7 @@ dns_resolver = NONE
dns_hostsfile = /etc/hosts
dns_order = LAST,SRV,A,CNAME
dns_valid_ttl = NONE
dns_stale_ttl = 4
dns_stale_ttl = 3600
dns_cache_size = 10000
dns_not_found_ttl = 30
dns_error_ttl = 1
Expand Down
Loading