fix(tracing): don't print error when passing nil to span:set_attribute #12079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
fix/allow-nil-span-attribute
branch
from
9d5e751 to
f6b9da3
Compare
samugi
changed the title
samugi
force-pushed
the
fix/allow-nil-span-attribute
branch
from
f6b9da3 to
a1af072
Compare
samugi
changed the title
samugi
force-pushed
the
fix/allow-nil-span-attribute
branch
from
a1af072 to
b043ac5
Compare
tzssangglass
approved these changes
Nov 24, 2023
kikito
approved these changes
Dec 1, 2023
* passing a nil value to `span:set_attribute` is a NOOP if the attribute does not already exists, else it means unsetting that attribute * considered a fix because previously this was causing a stack trace when the DNS spans were created without a port
samugi
force-pushed
the
fix/allow-nil-span-attribute
branch
from
b043ac5 to
8db31d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
An error log was printed whenever a nil attribute was set for a span. This implies every variable has to be nil-checked before it can be assigned to some span attribute. In general it feels more natural to expect that passing
nilis accepted without producing any error log or warning.span:set_attributeis a NOOP if the attribute does not already exist, else it means unsetting that attribute (just like before). Now both of these are applied silently, without printing an error.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]