fix(core): respect custom proxy_access_log #12073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsinre
force-pushed
the
FTI-5580/respect-custom-access-log
branch
from
316fd43 to
989e307
Compare
outsinre
force-pushed
the
FTI-5580/respect-custom-access-log
branch
from
989e307 to
4df129e
Compare
outsinre
changed the title
outsinre
changed the title
outsinre
force-pushed
the
FTI-5580/respect-custom-access-log
branch
from
4df129e to
d03245e
Compare
outsinre
force-pushed
the
FTI-5580/respect-custom-access-log
branch
2 times, most recently
from
b6fa973 to
e61dac3
Compare
|
A similar bug to #11712. |
samugi
reviewed
Nov 22, 2023
outsinre
force-pushed
the
FTI-5580/respect-custom-access-log
branch
from
e61dac3 to
6a03c7c
Compare
Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value.
outsinre
force-pushed
the
FTI-5580/respect-custom-access-log
branch
from
6a03c7c to
6381b5c
Compare
outsinre
commented
Nov 22, 2023
samugi
reviewed
Nov 22, 2023
kong/cmd/utils/prefix_handler.lua
Outdated
| compile_env.proxy_access_log_enabled = true | ||
| end | ||
| if kong_proxy_access_log then | ||
| -- example: 'logs/some-file.log apigw_json' |
There was a problem hiding this comment.
-- example: proxy_access_log = logs/some-file.log apigw_json
is it more clear?
samugi
approved these changes
Nov 24, 2023
team-gateway-bot
pushed a commit
that referenced
this pull request
Nov 28, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments (cherry picked from commit 9ec3494)
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/3.4.x release/3.4.x
# Navigate to the new working tree
cd .worktrees/backport-release/3.4.x
# Create a new branch
git switch --create backport-12073-to-release/3.4.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ec3494cb558ee03223218c7c74003f8bce3b267
# Push it to GitHub
git push --set-upstream origin backport-12073-to-release/3.4.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/3.4.xThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-release/2.8.x release/2.8.x
# Navigate to the new working tree
cd .worktrees/backport-release/2.8.x
# Create a new branch
git switch --create backport-12073-to-release/2.8.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 9ec3494cb558ee03223218c7c74003f8bce3b267
# Push it to GitHub
git push --set-upstream origin backport-12073-to-release/2.8.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-release/2.8.xThen, create a pull request where the |
outsinre
added a commit
that referenced
this pull request
Nov 28, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments
fffonion
pushed a commit
that referenced
this pull request
Nov 29, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments (cherry picked from commit 9ec3494)
fffonion
pushed a commit
that referenced
this pull request
Nov 29, 2023
* fix(core): respect custom proxy_access_log Kong now has a fixed access log format `kong_log_format` that prevents customization and error on `kong start`. Related to #11663. If the `proxy_access_log` is not a valid pathname, then replace `kong_log_format` with the custom value. * fix(config): cover log_format name with hyphen * fix(config): early error when access log format is not defined * fix(config): discard warning or return nil * chore(config): style and comments * chore(*): comments
1 task
This was referenced Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Kong now has a fixed access log format
kong_log_formatthat prevents customization. Introduced by #11663.Resolves #12061.
If the
proxy_access_loghas a log format specified, then replacekong_log_formatwith the custom value.Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
kong_log_formatwith custom value set by end users.Issue reference
Fix #FTI-5580