Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plugin(datadog): fix a bug that datalog plugin is not triggered for serviceless routes #12068

Merged
merged 2 commits into from
Nov 23, 2023
Merged

plugin(datadog): fix a bug that datalog plugin is not triggered for serviceless routes #12068

merged 2 commits into from
Nov 23, 2023

Conversation

liverpool8056
Copy link
Contributor

@liverpool8056 liverpool8056 commented Nov 21, 2023 •
edited
Loading

Summary

fix a bug that datadog plugin is not triggered for serviceless routes.

In this PR, the datadog plugin can be triggered even if the serviceless routes are hit, and the value of tag name for the metric data is set to an empty string which is still a valid tag for datadog.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

FTI-5576

@liverpool8056 liverpool8056 force-pushed the fix/serverless-routes-still-trigger-datalog-plugin branch from 5d56179 to 8888d67 Compare November 21, 2023 03:29
@liverpool8056 liverpool8056 force-pushed the fix/serverless-routes-still-trigger-datalog-plugin branch from 50687f3 to 91a485a Compare November 22, 2023 03:02
@liverpool8056 liverpool8056 changed the title plugin(datadog): fix a bug that datalog plugin is not triggered for serverless routes plugin(datadog): fix a bug that datalog plugin is not triggered for serviceless routes Nov 22, 2023
@liverpool8056 liverpool8056 force-pushed the fix/serverless-routes-still-trigger-datalog-plugin branch from 91a485a to 2081925 Compare November 22, 2023 05:39
tzssangglass
tzssangglass approved these changes Nov 22, 2023
View reviewed changes
Copy link
Member

@tzssangglass tzssangglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liverpool8056 liverpool8056 force-pushed the fix/serverless-routes-still-trigger-datalog-plugin branch from 2081925 to c167c3e Compare November 23, 2023 03:55
@pull-request-size pull-request-size bot added size/L and removed size/M labels Nov 23, 2023
@liverpool8056 liverpool8056 force-pushed the fix/serverless-routes-still-trigger-datalog-plugin branch from dee259d to 5dd913b Compare November 23, 2023 05:10
@windmgc windmgc merged commit c976cbe into master Nov 23, 2023
23 checks passed
@windmgc windmgc deleted the fix/serverless-routes-still-trigger-datalog-plugin branch November 23, 2023 07:29
@liverpool8056 liverpool8056 added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 23, 2023
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

@windmgc windmgc windmgc approved these changes

Assignees

@liverpool8056 liverpool8056

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/datadog size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@liverpool8056 @team-gateway-bot @windmgc @tzssangglass @oowl