-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(conf_loader): separate constants from conf_loader core #12055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chronolaw
changed the title
refactor(conf_loader): separate constants from conf_loader
refactor(conf_loader): separate constants from conf_loader core
Nov 18, 2023
chronolaw
added
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Nov 20, 2023
gszr
reviewed
Nov 22, 2023
gszr
reviewed
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice refactor; left a minor readability comment. Otherwise, LGTM.
zhongweiy
reviewed
Nov 22, 2023
zhongweiy
approved these changes
Nov 22, 2023
chronolaw
removed
the
cherry-pick kong-ee
schedule this PR for cherry-picking to kong/kong-ee
label
Nov 24, 2023
tzssangglass
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
chronolaw
force-pushed
the
refactor/constants_for_conf_loader
branch
from
November 29, 2023 03:26
4037349
to
c6013fc
Compare
chronolaw
force-pushed
the
refactor/constants_for_conf_loader
branch
from
November 29, 2023 03:41
2aeb0be
to
1cbecf8
Compare
fffonion
reviewed
Nov 29, 2023
gszr
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
conf_loader.init
has too many lines and is too complex, it is hard to understand and maintain,I try to move out some code to simplify it.
KAG-3128
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdFull changelog
conf_loader.constants
Issue reference
Fix #[issue number]