Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(conf_loader): separate constants from conf_loader core #12055

Merged
merged 13 commits into from
Nov 29, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 18, 2023

Summary

conf_loader.init has too many lines and is too complex, it is hard to understand and maintain,
I try to move out some code to simplify it.

KAG-3128

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • a new module conf_loader.constants
  • cipher_suites => CIPHER_SUITES
  • typ_checks => TYP_CHECKS
  • _NOP_TOSTRING_MT
  • use CONF_SENSITIVE_PLACEHOLDER to replace "******"

Issue reference

Fix #[issue number]

@chronolaw chronolaw changed the title refactor(conf_loader): separate constants from conf_loader refactor(conf_loader): separate constants from conf_loader core Nov 18, 2023
@chronolaw chronolaw marked this pull request as ready for review November 18, 2023 13:09
@chronolaw chronolaw marked this pull request as draft November 18, 2023 13:30
@chronolaw chronolaw marked this pull request as ready for review November 18, 2023 23:27
@chronolaw chronolaw added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 20, 2023
@locao locao requested review from zhongweiy and gszr November 21, 2023 17:50
kong/conf_loader/init.lua Outdated Show resolved Hide resolved
Copy link
Member

@gszr gszr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice refactor; left a minor readability comment. Otherwise, LGTM.

kong/conf_loader/init.lua Outdated Show resolved Hide resolved
@chronolaw chronolaw requested a review from gszr November 22, 2023 23:40
@chronolaw chronolaw removed the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Nov 24, 2023
Copy link
Member

@tzssangglass tzssangglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chronolaw chronolaw force-pushed the refactor/constants_for_conf_loader branch from 4037349 to c6013fc Compare November 29, 2023 03:26
@chronolaw chronolaw force-pushed the refactor/constants_for_conf_loader branch from 2aeb0be to 1cbecf8 Compare November 29, 2023 03:41
kong/conf_loader/init.lua Outdated Show resolved Hide resolved
@gszr gszr merged commit a4369e7 into master Nov 29, 2023
24 checks passed
@gszr gszr deleted the refactor/constants_for_conf_loader branch November 29, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants