fix(scripts): fix update-copyright in venv and remove unused repos #12022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fffonion
force-pushed
the
fix-copyright-update
branch
from
feac6cc to
2b238b6
Compare
gszr
approved these changes
Nov 29, 2023
3 tasks
locao
approved these changes
Nov 29, 2023
| @@ -420,6 +422,7 @@ table.sort(rocks, function(a, b) return a.package:lower() < b.package:lower() en | |||
|
|
|||
| print("Searching and downloading license texts from rock repos") | |||
| for _, rock in ipairs(rocks) do | |||
| break | |||
There was a problem hiding this comment.
The break will skip the rest of code, shall we remove the for loop from the source code?
There was a problem hiding this comment.
nvm. It's already fixed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]
Replaces #11947
Sister PR https://github.com/Kong/kong-ee/pull/7279