-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tools): separate module-related functions from tool.utils #12018
Conversation
f5b9808
to
1060a55
Compare
this only involves one function so doesn't seem to worth seperate into a different file? |
@fffonion The Currently, this process is divided into three steps:
Therefore, it still needs to be separated. |
Are we going to see the final step too that moves things in PDK? :-) |
I think that pdk is another topic, refactoring of pdk may be more careful. |
Yes, there is then opportunity to think things better, test things better, document things better... but that should be the ultimate goal as these utils are most useful with plugin developers. |
Signed-off-by: Aapo Talvensaari <[email protected]>
b9d8bf4
to
e0dea18
Compare
Summary
Move module-related functions from
kong/tools/utils.lua
tokong/tools/module.lua
.Issue reference
KAG-2960