Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tools): separate module-related functions from tool.utils #12018

Merged
merged 4 commits into from
Nov 15, 2023

Conversation

Water-Melon
Copy link
Contributor

@Water-Melon Water-Melon commented Nov 15, 2023

Summary

Move module-related functions from kong/tools/utils.lua to kong/tools/module.lua.

Issue reference

KAG-2960

@Water-Melon Water-Melon force-pushed the refactor/separate_module_from_tools branch from f5b9808 to 1060a55 Compare November 15, 2023 06:58
@Water-Melon Water-Melon marked this pull request as ready for review November 15, 2023 07:50
kong/tools/module.lua Show resolved Hide resolved
kong/tools/module.lua Outdated Show resolved Hide resolved
@fffonion
Copy link
Contributor

this only involves one function so doesn't seem to worth seperate into a different file?

@Water-Melon
Copy link
Contributor Author

Water-Melon commented Nov 15, 2023

this only involves one function so doesn't seem to worth seperate into a different file?

@fffonion The kong/tools/utils.lua will be removed.

Currently, this process is divided into three steps:

  • The first step involves splitting the content of kong/tools/utils.lua and categorizing it into various files
  • The second step is to correct all external dependencies of each component.
  • The last step is to remove kong/tools/utils.lua.

Therefore, it still needs to be separated.

@bungle
Copy link
Member

bungle commented Nov 15, 2023

  • The last step is to remove kong/tools/utils.lua.

Are we going to see the final step too that moves things in PDK? :-)

@chronolaw
Copy link
Contributor

  • The last step is to remove kong/tools/utils.lua.

Are we going to see the final step too that moves things in PDK? :-)

I think that pdk is another topic, refactoring of pdk may be more careful.

@bungle
Copy link
Member

bungle commented Nov 15, 2023

  • The last step is to remove kong/tools/utils.lua.

Are we going to see the final step too that moves things in PDK? :-)

I think that pdk is another topic, refactoring of pdk may be more careful.

Yes, there is then opportunity to think things better, test things better, document things better... but that should be the ultimate goal as these utils are most useful with plugin developers.

@bungle bungle force-pushed the refactor/separate_module_from_tools branch from b9d8bf4 to e0dea18 Compare November 15, 2023 08:52
@bungle bungle merged commit df2105d into master Nov 15, 2023
23 checks passed
@bungle bungle deleted the refactor/separate_module_from_tools branch November 15, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants