Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(tools): ngx.var.scheme is always lower case #12000

Closed
wants to merge 1 commit into from

Conversation

chronolaw
Copy link
Contributor

Summary

As the nginx's doc and source shows, the var $scheme is always lower case string https,
so the call lower() is unnecessary.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw
Copy link
Contributor Author

$schema could be rewrite to upper case, so we still need lower()

@chronolaw chronolaw closed this Nov 12, 2023
@chronolaw chronolaw deleted the style/ngx_var_https_always_lower branch November 12, 2023 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant