Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(router): only load configured flavor module #11997

Merged
merged 3 commits into from
Nov 27, 2023
Merged

refactor(router): only load configured flavor module #11997

merged 3 commits into from
Nov 27, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 11, 2023 •
edited
Loading

Summary

Kong gateway only use one flavor when it starts, we need not to load all router modules at once.
This will reduce the usage of memory to a degree.

KAG-3135

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as ready for review November 11, 2023 03:40
@StarlightIbuki
Copy link
Contributor

Please add links to the issue.

@locao locao requested a review from gruceo November 21, 2023 17:46
tzssangglass
tzssangglass approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@tzssangglass tzssangglass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fffonion fffonion merged commit 53d50e7 into master Nov 27, 2023
25 checks passed
@fffonion fffonion deleted the refactor/require_router_when_needed branch November 27, 2023 06:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gruceo gruceo gruceo approved these changes

@StarlightIbuki StarlightIbuki StarlightIbuki approved these changes

@tzssangglass tzssangglass tzssangglass approved these changes

Assignees

@chronolaw chronolaw

Labels
size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chronolaw @StarlightIbuki @tzssangglass @gruceo @fffonion