-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(tools): remove gzip module reference in utils.lua #11985
Conversation
@chronolaw, It is reasonable as evolutionary step. But what do you think about introducing stuff in PDK (or in PDK too), then we could most of the time just remove |
Does pdk have such requirement? If we do need it I think we could add it. |
What do you mean does plugin developer kit have such requirement? Lua especially doesn't come with batteries included. But as seen on many of our plugins, we need batteries all the time. If those batteries were in PDK that would make it much nicer experience for Lua plugin writers to write plugins. Because then they don't need to install random rocks (how to hack them in custom builds etc), think that are they blocking etc. We have suite of tools/utils that everyone can use. Our scope is quite limited (proxying problem space), so it never has to be as big as something general purpose as JDK. But definitely it can be bigger than it currently is:
The list goes on. We can just look our plugins to see what is common and then start putting things in PDK. That said, this is unrelated to this PR, but slightly related if we think things more broadly. |
It looks very interesting, I am not very familiar with pdk development workflow, should we create some jira ticket to track it? |
@chronolaw Ticket #? |
|
Summary
utils.lua
includes many small modules, after some refactor PRs, it's time to use them directly.This PR remove gzip functions from
utils.lua
, now we should userequire("kong.tools.gzip")
.Do you think it is reasonable?
KAG-3060
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]