[backport -> release/3.4.x] feat(request-id): introduce Request ID #11970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samugi
force-pushed
the
cherry-pick/request-id-11624
branch
from
76ad311 to
3747231
Compare
samugi
force-pushed
the
cherry-pick/request-id-11624-2
branch
from
157b695 to
fa9332f
Compare
samugi
changed the title
3 tasks
samugi
force-pushed
the
cherry-pick/request-id-11624-2
branch
2 times, most recently
from
176d458 to
e440a3b
Compare
samugi
force-pushed
the
cherry-pick/request-id-11624
branch
3 times, most recently
from
50a1d75 to
f3e5fb1
Compare
Base automatically changed from
cherry-pick/request-id-11624
to
release/3.4.x
November 15, 2023 08:54
samugi
force-pushed
the
cherry-pick/request-id-11624-2
branch
from
e440a3b to
ddc716a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
* feat(request-id): add Request ID
* Add an immutable request ID
* Include request ID + trace and correlation IDs to the log serializer
* update Access log and Error log to append request id
* update the error templates to include the request id
* Bump lua-kong-nginx-module to version 0.7.1
* Use the new directive `lua_kong_error_log_request_id`
introduced in 0.7.0 which adds the request id to the error log output
Includes:
* unit tests for the new `request_id` module
* integration tests to check:
* request id, correlation id, trace ids are added to log serializer
* feat(request-id): add request-id to error templates
* feat(request-id): request ID header + span attribute
* add the x-kong-request-id downstream header which contains the value
of the request_id, and can be controlled via the `headers` config
option
* add the x-kong-request-id upstream header which contains the value
of the request_id, and can be controlled via the `headers_upstream`
config option
* add the `kong.request.id` span attribute which contains the value of
the request_id
* tests for all the above
* docs(conf): request ID
Co-authored-by: Enrique García Cota <[email protected]>
* feat(request-id): address PR feedback
* rephrase log messages
* remove unneeded conditional
* better changelog
* use upvalues to cache headers access
* use request id instead of kong_request_id (no longer needed as we
don't need write access)
* cache locals in hot path
* improved performance of add_trace_id_formats function
* refactored docs in kong.conf.default
* perf: cache `request_id.get()` at the module level
KAG-2034
FTI-4837
---------
Co-authored-by: samugi <[email protected]>
Co-authored-by: Enrique García Cota <[email protected]>
Co-authored-by: Qi <[email protected]>
samugi
force-pushed
the
cherry-pick/request-id-11624-2
branch
from
ddc716a to
2befdb0
Compare
nowNick
approved these changes
Nov 16, 2023
|
@chronolaw @chobits please review this backport. |
chobits
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Backport of:
feat(request-id): introduce Request ID #11624[reopened] feat(request-id): introduce Request ID #11663to port the request ID feature to release/3.4.x
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
KAG-3040