Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pdk): move ffi.cdef gethostname from tools into pdk #11967

Merged
merged 2 commits into from
Nov 10, 2023
Merged

refactor(pdk): move ffi.cdef gethostname from tools into pdk #11967

merged 2 commits into from
Nov 10, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 9, 2023 •
edited
Loading

Summary

gethostname is only used by pdk, it should not be in utils.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw requested a review from Water-Melon November 9, 2023 09:36
@windmgc windmgc merged commit 13d3d57 into master Nov 10, 2023
23 checks passed
@windmgc windmgc deleted the refactor/clean_pdk_gethostname branch November 10, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tzssangglass tzssangglass tzssangglass approved these changes

@windmgc windmgc windmgc approved these changes

@bungle bungle bungle approved these changes

@Water-Melon Water-Melon Awaiting requested review from Water-Melon

Assignees

@chronolaw chronolaw

Labels
core/pdk size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @bungle @windmgc @tzssangglass