Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(tools): move sort_by_handler_priority to DAO #11965

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

Water-Melon
Copy link
Contributor

KAG-2956

Summary

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@Water-Melon Water-Melon force-pushed the refactor/move_sort_to_dao branch from 0382480 to fac0437 Compare November 9, 2023 07:51
@Water-Melon Water-Melon requested a review from jschmid1 November 9, 2023 08:09
@chronolaw chronolaw marked this pull request as ready for review November 9, 2023 09:13
@Water-Melon
Copy link
Contributor Author

The function sort_by_handler_priority is only used in DAO and does not belong to any other category of functions in kong/tools/utils.lua, so it should be moved to DAO.

@Water-Melon Water-Melon removed the request for review from jschmid1 November 9, 2023 09:19
@windmgc windmgc merged commit 53ab40a into master Nov 9, 2023
23 checks passed
@windmgc windmgc deleted the refactor/move_sort_to_dao branch November 9, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants