Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(tools): cache lower(unit) for bytes_to_str() #11920

Merged
merged 1 commit into from
Nov 6, 2023
Merged

refactor(tools): cache lower(unit) for bytes_to_str() #11920

merged 1 commit into from
Nov 6, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Nov 6, 2023 •
edited
Loading

Summary

Cache the result of lower(unit) in bytes_to_str(), avoiding duplicated calcuation.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@bungle bungle merged commit 48664d5 into master Nov 6, 2023
34 checks passed
@bungle bungle deleted the refactor/optimize_bytes_to_str branch November 6, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bungle bungle bungle approved these changes

Assignees

@chronolaw chronolaw

Labels
size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chronolaw @bungle