Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(clustering): simplify parse_proxy_url() #11799

Merged
merged 1 commit into from
Oct 23, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Oct 20, 2023

Summary

Simplify the params of parse_proxy_url().

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

Copy link
Contributor

@chobits chobits left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And later we can move the clustering/utils.lua to some high-level utils directory.

@chronolaw
Copy link
Contributor Author

And later we can move the clustering/utils.lua to some high-level utils directory.

We are planing to redesign CP/DP, these code will became a legacy, I think that it will not have big change recently.

@windmgc windmgc merged commit bab36ea into master Oct 23, 2023
34 checks passed
@windmgc windmgc deleted the refactor/simplify_parse_proxy_url branch October 23, 2023 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants