fix(vault): properly warmups the cache on init #11793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
force-pushed
the
fix/vault-init-cache
branch
from
e20432c to
e3b2506
Compare
flrgh
force-pushed
the
fix/vault-init-cache
branch
from
e3b2506 to
ae27f5b
Compare
chronolaw
reviewed
Oct 20, 2023
bungle
force-pushed
the
fix/vault-init-cache
branch
from
ae27f5b to
05d06ac
Compare
jschmid1
approved these changes
Oct 24, 2023
bungle
force-pushed
the
fix/vault-init-cache
branch
4 times, most recently
from
5a3adf6 to
677a64c
Compare
### Summary
Fixes issue where this was logged to logs:
```
2023/10/18 13:53:33 [warn] 8714#0: [kong] vault.lua:861 error updating secret reference {vault://env/PG_USER}: could not find cached value
```
That happened for example when starting Kong with this command:
```
KONG_LOG_LEVEL=warn PG_USER=kong KONG_PG_USER={vault://env/PG_USER} ./bin/kong start
```
It auto-corrected itself, which was good in this case.
This commit makes it more robust, and does not warn anymore
as caches are properly warmed.
Signed-off-by: Aapo Talvensaari <[email protected]>
bungle
force-pushed
the
fix/vault-init-cache
branch
from
677a64c to
762316b
Compare
team-gateway-bot
pushed a commit
that referenced
this pull request
Oct 24, 2023
### Summary
Fixes issue where this was logged to logs:
```
2023/10/18 13:53:33 [warn] 8714#0: [kong] vault.lua:861 error updating secret reference {vault://env/PG_USER}: could not find cached value
```
That happened for example when starting Kong with this command:
```
KONG_LOG_LEVEL=warn PG_USER=kong KONG_PG_USER={vault://env/PG_USER} ./bin/kong start
```
It auto-corrected itself, which was good in this case.
This commit makes it more robust, and does not warn anymore
as caches are properly warmed.
Signed-off-by: Aapo Talvensaari <[email protected]>
(cherry picked from commit d8bd50d)
bungle
added a commit
that referenced
this pull request
Oct 24, 2023
### Summary
Fixes issue where this was logged to logs:
```
2023/10/18 13:53:33 [warn] 8714#0: [kong] vault.lua:861 error updating secret reference {vault://env/PG_USER}: could not find cached value
```
That happened for example when starting Kong with this command:
```
KONG_LOG_LEVEL=warn PG_USER=kong KONG_PG_USER={vault://env/PG_USER} ./bin/kong start
```
It auto-corrected itself, which was good in this case.
This commit makes it more robust, and does not warn anymore
as caches are properly warmed.
Signed-off-by: Aapo Talvensaari <[email protected]>
(cherry picked from commit d8bd50d)
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issue where this was logged to logs:
That happened for example when starting Kong with this command:
It auto-corrected itself, which was good in this case. This commit makes it more robust, and does not warn anymore as caches are properly warmed.