Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(pdk): a wrapper function for checking ngx.headers_sent #11769

Closed
wants to merge 2 commits into from
Closed

refactor(pdk): a wrapper function for checking ngx.headers_sent #11769

wants to merge 2 commits into from

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Oct 17, 2023 •
edited
Loading

Summary

We have too many duplicated code of checking ngx.headers_sent,
This PR creates a wrapper function for it.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@chronolaw chronolaw marked this pull request as draft October 17, 2023 05:26
@chronolaw
Copy link
Contributor Author

We need error(..., 2) to report the calling function, wrapper function hides this info.

@chronolaw chronolaw closed this Oct 17, 2023
@chronolaw chronolaw deleted the refactor/warp_checking_headers_sent branch October 17, 2023 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chronolaw chronolaw

Labels
core/pdk size/M skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@chronolaw