refactor(tools): separate yield functions from utils #11747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bungle
changed the title
Water-Melon
approved these changes
Oct 24, 2023
chronolaw
force-pushed
the
refactor/separate_yield_from_utils
branch
from
72d61df to
a200b73
Compare
chobits
approved these changes
Oct 24, 2023
chronolaw
force-pushed
the
refactor/separate_yield_from_utils
branch
from
a200b73 to
4c0f796
Compare
tzssangglass
approved these changes
Oct 24, 2023
chronolaw
force-pushed
the
refactor/separate_yield_from_utils
branch
from
4c0f796 to
89b8639
Compare
hanshuebner
previously requested changes
Oct 26, 2023
kong/tools/utils.lua
Outdated
| end | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
As we're planning to split up utils.lua even further, make this function into a utility function that can be called like:
include_module(_M, "kong.tools.yield")
or similar to prevent code duplication.
windmgc
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is one of serial refactor PRs, the goal is to clean the huge utils.lua.
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdFull changelog
Issue reference
Fix #[issue number]