Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(api): export yaml with string.buffer #11706

Merged
merged 3 commits into from
Oct 12, 2023
Merged

refactor(api): export yaml with string.buffer #11706

merged 3 commits into from
Oct 12, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Oct 7, 2023 •
edited
Loading

Summary

string.buffer has better performance than table.concat, we have already used it in other places.
This PR also refactored the function truthy().

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Oct 7, 2023
@dndx dndx merged commit 425451c into master Oct 12, 2023
32 checks passed
@dndx dndx deleted the refactor/export_yaml_with_string_buffer branch October 12, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Water-Melon Water-Melon Water-Melon approved these changes

@dndx dndx dndx approved these changes

Assignees

@chronolaw chronolaw

Labels
core/admin-api size/S skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chronolaw @dndx @Water-Melon