Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(rate-limiting): fix a flaky test #11705

Merged
merged 1 commit into from
Oct 13, 2023
Merged

tests(rate-limiting): fix a flaky test #11705

merged 1 commit into from
Oct 13, 2023

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Oct 7, 2023 •
edited
Loading

Summary

We should not use with_max_retries for the expire counter tests as the default step is 0.05 (too small to across a window).

Checklist

  • [N/A] The Pull Request has tests
  • [N/A] A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-2667

@ADD-SP ADD-SP force-pushed the add_sp/test-fix-rl-flaky branch from dc4eabf to 4235484 Compare October 7, 2023 06:20
@ADD-SP ADD-SP marked this pull request as ready for review October 7, 2023 06:59
@ADD-SP ADD-SP requested a review from outsinre October 9, 2023 07:21
@ADD-SP ADD-SP force-pushed the add_sp/test-fix-rl-flaky branch from 4235484 to 50a7fe9 Compare October 9, 2023 08:12
@ADD-SP ADD-SP requested a review from outsinre October 10, 2023 07:53
@ADD-SP ADD-SP added the pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) label Oct 10, 2023
@dndx dndx merged commit 9bf6f85 into master Oct 13, 2023
25 checks passed
@dndx dndx deleted the add_sp/test-fix-rl-flaky branch October 13, 2023 02:47
@AndyZhang0707
Copy link
Collaborator

@ADD-SP please cherry-pick to EE. thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@outsinre outsinre outsinre approved these changes

Assignees

@ADD-SP ADD-SP

Labels
pr/ready This PR is considered ready and can be merged at anytime (given it received no subsequent changes) size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ADD-SP @AndyZhang0707 @outsinre @dndx