tests(request-debug): improve integration tests #11692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the test setup logic such that helpers.get_db_utils() is only invoked once per test DB strategy. BEFORE: ======= 30 tests from 1 test file ran. (64157.77 ms total) AFTER: ======= 30 tests from 1 test file ran. (52507.36 ms total)
This updates the tests to truncate the error.log file before making a request that will generate a log entry. The goal is to reduce the overall amount of bytes that must be read from disk and searched through.
This updates the request debug log entry logic to use `io.lines()` rather than reading the whole file at once. This improves performance and memory usage in the worst-case scenarios of the function.
locao
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This includes several changes designed to make the request-debug test suite faster and less memory-intensive.
This test suite is occasionally triggering the OOMKiller in our Enterprise CI runs, and this changeset aims to stop the bleeding.
Checklist
CHANGELOG/unreleased/kongor addingskip-changeloglabel on PR if unnecessary. README.mdThere is a user-facing docs PR against https://github.com/Kong/docs.konghq.comFull changelog
helpers.get_db_utils())error.logbefore running testserror.logline-by-line instead of all at onceIssue reference
KAG-2710