Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(DEVELOPER): clarify permission for Github Access Token #11561

Merged
merged 1 commit into from
Sep 19, 2023

Conversation

nowNick
Copy link
Contributor

@nowNick nowNick commented Sep 13, 2023

Summary

When setting up Kong DEVELOPER.md points to Github Documentation to generate a Github Access Token in order to download some essential repos. However it does not explicitly state what permissions the token should grant.

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • DEVELOPER.md: Mention that no additional permission are needed when setting up Kong

Issue reference

N/A

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@chronolaw chronolaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Job!

@nowNick nowNick force-pushed the docs/clarify-scope-for-gh-acces-token branch 3 times, most recently from a64a569 to 5c54352 Compare September 19, 2023 06:44
When setting up Kong `DEVELOPER.md` points to Github Documentation
to generate a Github Access Token in order to download some essential
repos. Unfortunately it does not explicitly state what permissions
the token should grant. Add a note that it only needs
Public Repositories (read-only) permission.
@nowNick nowNick force-pushed the docs/clarify-scope-for-gh-acces-token branch from 5c54352 to 92c8459 Compare September 19, 2023 06:50
@samugi samugi merged commit 93d40a1 into master Sep 19, 2023
@samugi samugi deleted the docs/clarify-scope-for-gh-acces-token branch September 19, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants