[Backport release/3.4.x] fix(tracing): span start/end time precision #11556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(tracing): span start/end time precision Ensure the span lifetime is consistent with the hierarchy by using the same time source for the root span's end time as the balancer span. Before this fix, an approximation (causing a precision error) could result in the root span to end before its children. * docs(changelog): add issue Co-authored-by: Xumin <[email protected]> --------- Co-authored-by: Xumin <[email protected]> (cherry picked from commit 37a17eb)
samugi
approved these changes
Sep 13, 2023
|
@samugi Should this be in 3.4.1.0? cherry-pick to EE next/3.4.x.x? |
|
thanks @outsinre --> https://github.com/Kong/kong-ee/pull/6555 (it has the backport label) |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 37a17eb from #11484.