Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(build): support build wasmx module with wasmx and v8 runtime #11446

Closed
wants to merge 2 commits into from
Closed

feat(build): support build wasmx module with wasmx and v8 runtime #11446

wants to merge 2 commits into from

Conversation

fffonion
Copy link
Contributor

@fffonion fffonion commented Aug 23, 2023 •
edited by curiositycasualty
Loading

@github-actions github-actions bot added chore Not part of the core functionality of kong, but still needed build/bazel labels Aug 23, 2023
@AndyZhang0707 AndyZhang0707 requested a review from flrgh August 29, 2023 08:34
flrgh
flrgh approved these changes Aug 30, 2023
View reviewed changes
Copy link
Contributor

@flrgh flrgh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good to me thus far; feel free to re-request for review later if this is still WIP

@kikito kikito marked this pull request as draft September 12, 2023 08:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 8, 2023

This PR is marked as stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Oct 8, 2023
@curiositycasualty
Copy link
Contributor

rebased on master

@curiositycasualty
Copy link
Contributor

curiositycasualty commented Nov 29, 2023 •
edited by jira bot
Loading

Closing per KAG-2682.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flrgh flrgh flrgh approved these changes

Assignees

@fffonion fffonion

Labels
build/bazel chore Not part of the core functionality of kong, but still needed size/L stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fffonion @curiositycasualty @flrgh