fix(grpc-web): fix missing allowed headers for grpc deadlines #11368
Conversation
|
|
hanshuebner
added
the
author/community
|
Could you add a change log entry for this PR. See: https://github.com/Kong/kong/blob/master/CHANGELOG/README.md |
chronolaw
added
the
pending author feedback
| @@ -178,5 +178,19 @@ for _, strategy in helpers.each_strategy() do | |||
| assert.same({ reply = "hello heya" }, cjson.decode((res:read_body()))) | |||
| assert.is_nil(err) | |||
| end) | |||
|
|
|||
| test("Call binary gRCP via HTTP with a deadline", function() | |||
| local res, err = proxy_client:post("/hello.HelloService/SayHello", { | |||
There was a problem hiding this comment.
I think it might be better to provide two tests, one is about the test case that grpc_timeout can take effect, and the other is using the OPTIONS request to get the Access-Control-Allow-Headers response with grpc_timeout.
There was a problem hiding this comment.
@Water-Melon Would you mind taking this over so we can get the fix merged?
Acces-Control-Allow-Headers is missing an header which make it impossible to use deadlines with grpc calls, the header is "grpc-timeout". #11185 https://github.com/grpc/grpc-web/blob/9c48d290b2a978c0662dabe5123ed05923054bce/javascript/net/grpc/web/grpcwebclientbase.js#L332
Co-authored-by: Chrono <[email protected]>
|
This PR is marked as stale because it has been open for 14 days with no activity. |
|
Dear contributor, We are automatically closing this pull request because it has not seen any activity for three weeks. Your contribution is greatly appreciated! Please have a look Sincerely, |
Acces-Control-Allow-Headers is missing an header which make it impossible to use deadlines with grpc calls, the header is "grpc-timeout".
#11185
https://github.com/grpc/grpc-web/blob/9c48d290b2a978c0662dabe5123ed05923054bce/javascript/net/grpc/web/grpcwebclientbase.js#L332
Summary
Fix that make deadline usable with grpc-web plugin.
Checklist
Full changelog
Issue reference
Fix #11185