-
Notifications
You must be signed in to change notification settings - Fork 4.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(sessions): store session's meatadata
- Loading branch information
1 parent
88ffdda
commit b033733
Showing
10 changed files
with
143 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,20 +1,39 @@ | ||
local typedefs = require "kong.db.schema.typedefs" | ||
|
||
|
||
return { | ||
{ | ||
primary_key = { "id" }, | ||
endpoint_key = "session_id", | ||
name = "sessions", | ||
cache_key = { "session_id" }, | ||
ttl = true, | ||
db_export = false, | ||
fields = { | ||
{ id = typedefs.uuid }, | ||
{ session_id = { type = "string", unique = true, required = true } }, | ||
{ expires = { type = "integer" } }, | ||
{ data = { type = "string" } }, | ||
{ created_at = typedefs.auto_timestamp_s }, | ||
} | ||
local sessions = { | ||
primary_key = { "id" }, | ||
endpoint_key = "session_id", | ||
name = "sessions", | ||
cache_key = { "session_id" }, | ||
ttl = true, | ||
db_export = false, | ||
fields = { | ||
{ id = typedefs.uuid }, | ||
{ session_id = { type = "string", unique = true, required = true } }, | ||
{ expires = { type = "integer" } }, | ||
{ data = { type = "string" } }, | ||
{ created_at = typedefs.auto_timestamp_s }, | ||
} | ||
} | ||
|
||
local session_metadatas = { | ||
primary_key = { "id" }, | ||
name = "session_metadatas", | ||
dao = "kong.plugins.session.daos.session_metadatas", | ||
generate_admin_api = false, | ||
db_export = false, | ||
fields = { | ||
{ id = typedefs.uuid }, | ||
{ session = { type = "foreign", reference = "sessions", required = true, on_delete = "cascade" } }, | ||
{ sid = { type = "string" } }, | ||
{ audience = { type = "string" } }, | ||
{ subject = { type = "string" } }, | ||
{ created_at = typedefs.auto_timestamp_s }, | ||
} | ||
} | ||
|
||
return { | ||
sessions, | ||
session_metadatas, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
local session_metadatas = {} | ||
|
||
function session_metadatas:select_by_audience_and_subject(audience, subject) | ||
return self.strategy:select_by_audience_and_subject(audience, subject) | ||
end | ||
|
||
function session_metadatas:select_by_sid(sid) | ||
local cache_key = kong.db.sessions:cache_key(sid) | ||
local session = kong.cache:get(cache_key) or {} | ||
|
||
local res = {} | ||
for row in kong.db.session_metadatas:each_for_session({ id = session.id }) do | ||
table.insert(res, row) | ||
end | ||
return res | ||
end | ||
|
||
return session_metadatas |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
return { | ||
postgres = { | ||
up = [[ | ||
CREATE TABLE IF NOT EXISTS session_metadatas( | ||
id uuid, | ||
session_id uuid REFERENCES "sessions" ("id") ON DELETE CASCADE, | ||
sid text UNIQUE, | ||
subject text, | ||
audience text, | ||
created_at timestamp WITH TIME ZONE, | ||
PRIMARY KEY (id) | ||
); | ||
DO $$ | ||
BEGIN | ||
CREATE INDEX IF NOT EXISTS "session_id_idx" ON "session_metadatas" ("session_id"); | ||
EXCEPTION WHEN UNDEFINED_COLUMN THEN | ||
-- Do nothing, accept existing state | ||
END$$; | ||
]], | ||
}, | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,5 @@ return { | |
"000_base_session", | ||
"001_add_ttl_index", | ||
"002_320_to_330", | ||
"003_330_to_3100", | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
kong/plugins/session/strategies/postgres/session_metadatas.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
local fmt = string.format | ||
|
||
local session_metadatas = {} | ||
|
||
function session_metadatas:select_by_audience_and_subject(audience, subject) | ||
local qs = fmt( | ||
"SELECT * FROM session_metadatas WHERE audience = %s AND subject = %s;", | ||
kong.db.connector:escape_literal(audience), | ||
kong.db.connector:escape_literal(subject)) | ||
|
||
return kong.db.connector:query(qs, "read") | ||
end | ||
|
||
return session_metadatas |
18 changes: 18 additions & 0 deletions
18
spec/05-migration/plugins/session/migrations/003_330_to_3100_spec.lua
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,18 @@ | ||
local uh = require "spec/upgrade_helpers" | ||
|
||
describe("database migration", function () | ||
if uh.database_type() == "postgres" then | ||
uh.all_phases("has created the expected new columns", function() | ||
assert.table_has_column("session_metadatas", "id", "uuid") | ||
assert.table_has_column("session_metadatas", "session_id", "uuid") | ||
assert.table_has_column("session_metadatas", "sid", "text") | ||
assert.table_has_column("session_metadatas", "subject", "text") | ||
assert.table_has_column("session_metadatas", "audience", "text") | ||
assert.table_has_column("session_metadatas", "created_at", "timestamp with time zone", "timestamp") | ||
end) | ||
|
||
uh.all_phases("has created the expected indexes", function() | ||
assert.table_has_index("session_metadatas", "session_id_idx") | ||
end) | ||
end | ||
end) |