chore(conf): enable dedicated_config_processing by default (#11889)

* chore: enable `dedicated_config_processing by default This reverts commit 6bccc87. * docs(dcp): remove a trailing space (cherry picked from commit 224dc33)
Kong · Oct 31, 2023 · 5fe6aba · 5fe6aba
1 parent 4fd3bc6
commit 5fe6aba
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/changelog/3.5.0/kong/dedicated_config_processing.yml b/changelog/3.5.0/kong/dedicated_config_processing.yml
@@ -1,4 +1,4 @@
 message: |
-    rename `privileged_agent` to `dedicated_config_processing.
+    rename `privileged_agent` to `dedicated_config_processing. Enable `dedicated_config_processing` by default
 type: feature
 scope: Core
diff --git a/kong.conf.default b/kong.conf.default
@@ -182,7 +182,7 @@
                                  # cache (i.e. when the configured
                                  # `mem_cache_size`) is full.
 
-#dedicated_config_processing = off # Enables or disables a special worker
+#dedicated_config_processing = on  # Enables or disables a special worker
                                    # process for configuration processing. This process
                                    # increases memory usage a little bit while
                                    # allowing to reduce latencies by moving some

diff --git a/kong/templates/kong_defaults.lua b/kong/templates/kong_defaults.lua
@@ -161,7 +161,7 @@ dns_not_found_ttl = 30
 dns_error_ttl = 1
 dns_no_sync = on
 
-dedicated_config_processing = off
+dedicated_config_processing = on
 worker_consistency = eventual
 worker_state_update_frequency = 5
 

diff --git a/spec/01-unit/03-conf_loader_spec.lua b/spec/01-unit/03-conf_loader_spec.lua
@@ -65,7 +65,7 @@ describe("Configuration loader", function()
     assert.same({}, conf.status_ssl_cert)
     assert.same({}, conf.status_ssl_cert_key)
     assert.same(nil, conf.privileged_agent)
-    assert.same(false, conf.dedicated_config_processing)
+    assert.same(true, conf.dedicated_config_processing)
     assert.same(false, conf.allow_debug_header)
     assert.is_nil(getmetatable(conf))
   end)
@@ -2020,7 +2020,7 @@ describe("Configuration loader", function()
         privileged_agent = "on",
       }))
       assert.same(nil, conf.privileged_agent)
-      assert.same(false, conf.dedicated_config_processing)
+      assert.same(true, conf.dedicated_config_processing)
       assert.equal(nil, err)
 
       -- no clobber
@@ -2419,7 +2419,6 @@ describe("Configuration loader", function()
         assert.matches(label.err, err)
       end
     end)
-
   end)
 
 end)
diff --git a/spec/kong_tests.conf b/spec/kong_tests.conf
@@ -25,7 +25,7 @@ anonymous_reports = off
 
 worker_consistency = strict
 
-dedicated_config_processing = off
+dedicated_config_processing = on
 
 dns_hostsfile = spec/fixtures/hosts