fix(db): pass "read" on read-only database operations

### Summary @jeremyjpj0916 mentions in discussion thread: https://github.com/Kong/kong/discussions/13513 That Kong may work unexpectedly or require write node for general operation. I did quick search and found couple of missing places where we don't give "read" as a parameter for readonly operations. This may not fix all the issues that we have for how resilient Kong nodes are for write node being offline, but at least it is obvious to fix these at first. Signed-off-by: Aapo Talvensaari <[email protected]> (cherry picked from commit c29db18)
Kong · Aug 20, 2024 · 5eca2b4 · 5eca2b4
1 parent f18e8ee
commit 5eca2b4
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/changelog/unreleased/kong/fix-db-read-only.yml b/changelog/unreleased/kong/fix-db-read-only.yml
@@ -0,0 +1,3 @@
+message: "Fixed an issue where 'read' was not always passed to Postgres read-only database operations."
+type: bugfix
+scope: Core
diff --git a/kong/db/strategies/postgres/plugins.lua b/kong/db/strategies/postgres/plugins.lua
@@ -33,7 +33,7 @@ function Plugins:select_by_ca_certificate(ca_id, limit, plugin_names)
     name_condition,
     limit_condition)
 
-  return connector:query(qs)
+  return connector:query(qs, "read")
 end
 
 return Plugins
diff --git a/kong/db/strategies/postgres/services.lua b/kong/db/strategies/postgres/services.lua
@@ -14,7 +14,7 @@ function Services:select_by_ca_certificate(ca_id, limit)
     kong.db.connector:escape_literal(ca_id),
     limit_condition)
 
-  return kong.db.connector:query(qs)
+  return kong.db.connector:query(qs, "read")
 end
 
 return Services
diff --git a/kong/db/strategies/postgres/tags.lua b/kong/db/strategies/postgres/tags.lua
@@ -94,7 +94,7 @@ local function page(self, size, token, options, tag)
 
   sql = fmt(sql, unpack(args))
 
-  local res, err = self.connector:query(sql)
+  local res, err = self.connector:query(sql, "read")
 
   if not res then
     return nil, self.errors:database_error(err)

diff --git a/kong/plugins/response-ratelimiting/policies/cluster.lua b/kong/plugins/response-ratelimiting/policies/cluster.lua
@@ -68,7 +68,7 @@ return {
         connector:escape_literal(service_id),
         connector:escape_literal(route_id))
 
-      local res, err = connector:query(q)
+      local res, err = connector:query(q, "read")
       if not res then
         return nil, err
       end