Skip to content

Commit

Permalink
fix(venv): reset PATH to original state on deactivate (#13875)
Browse files Browse the repository at this point in the history
### Summary

I found out that PATH was not returned to its original state on with `deactivate`
in fish shell. This fixes it.

Signed-off-by: bungle <[email protected]>
  • Loading branch information
bungle authored Nov 16, 2024
1 parent 4059a31 commit 3f9b184
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion build/templates/venv.fish
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ if test -n "$_OLD_KONG_VENV_PATH"
# restore old PATH first, if this script is called multiple times
set -gx PATH $_OLD_KONG_VENV_PATH
else
set _OLD_KONG_VENV_PATH $PATH
set -gx _OLD_KONG_VENV_PATH $PATH
end

function deactivate -d 'Exit Kong\'s venv and return to the normal environment.'
Expand Down

1 comment on commit 3f9b184

@github-actions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel Build

Docker image available kong/kong:3f9b184ddc20dd74d27a704d3a265c8941fd01bc
Artifacts available https://github.com/Kong/kong/actions/runs/11869089989

Please sign in to comment.