Skip to content

Commit

Permalink
fix(conf): set default value of dns_no_sync to on (#11869)
Browse files Browse the repository at this point in the history
This is a temporary workaround for the DNS client blocking issue until
a more permanent solution can be developed.

Fix FTI-5348

---------

Co-authored-by: Datong Sun <[email protected]>
  • Loading branch information
chobits and dndx authored Oct 27, 2023
1 parent ed798ec commit 3be2513
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
3 changes: 3 additions & 0 deletions changelog/unreleased/kong/fix_dns_enable_dns_no_sync.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
message: The default value of `dns_no_sync` option has been changed to `on`
type: bugfix
scope: Configuration
2 changes: 1 addition & 1 deletion kong.conf.default
Original file line number Diff line number Diff line change
Expand Up @@ -1543,7 +1543,7 @@

#dns_error_ttl = 1 # TTL in seconds for error responses.

#dns_no_sync = off # If enabled, then upon a cache-miss every
#dns_no_sync = on # If enabled, then upon a cache-miss every
# request will trigger its own dns query.
# When disabled multiple requests for the
# same name/type will be synchronised to a
Expand Down
2 changes: 1 addition & 1 deletion kong/templates/kong_defaults.lua
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ dns_stale_ttl = 4
dns_cache_size = 10000
dns_not_found_ttl = 30
dns_error_ttl = 1
dns_no_sync = off
dns_no_sync = on
dedicated_config_processing = off
worker_consistency = eventual
Expand Down

1 comment on commit 3be2513

@khcp-gha-bot
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel Build

Docker image available kong/kong:3be2513a60b9f5f0a89631ff17c202e6113981c0
Artifacts available https://github.com/Kong/kong/actions/runs/6666353117

Please sign in to comment.