Skip to content

Commit

Permalink
add a TODO for more structured tries
Browse files Browse the repository at this point in the history
  • Loading branch information
chobits committed Jul 12, 2024
1 parent 7ce9599 commit 37cf30d
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions kong/dns/client.lua
Original file line number Diff line number Diff line change
Expand Up @@ -381,7 +381,11 @@ local function resolve_query(self, name, qtype, tries)
if not answers then
stats_increment(self.stats, key, "query_fail_nameserver")
err = "DNS server error: " .. tostring(err) .. ", took " .. duration .. " ms"

-- TODO: make the error more structured, like:
-- { qname = name, qtype = qtype, error = err, } or something similar
table_insert(tries, { name .. ":" .. TYPE_TO_NAME[qtype], err })

return nil, err
end

Expand Down

0 comments on commit 37cf30d

Please sign in to comment.