Skip to content

Commit

Permalink
fix(vault): let vault entity cache key not containing workspace id
Browse files Browse the repository at this point in the history
  • Loading branch information
windmgc committed Sep 3, 2024
1 parent 4e38b96 commit 2732d15
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
10 changes: 10 additions & 0 deletions kong/db/dao/vaults.lua
Original file line number Diff line number Diff line change
Expand Up @@ -84,4 +84,14 @@ function Vaults:load_vault_schemas(vault_set)
end


function Vaults:cache_key(prefix)
if type(prefix) == "table" then
prefix = prefix.prefix
end

-- Always return the cache_key without a workspace because prefix is unique across workspaces
return "vaults:" .. prefix .. ":::::"
end


return Vaults
5 changes: 5 additions & 0 deletions spec/02-integration/13-vaults/01-vault_spec.lua
Original file line number Diff line number Diff line change
Expand Up @@ -175,5 +175,10 @@ for _, strategy in helpers.each_strategy() do
assert.is_equal("{vault://unknown/missing-key}", certificate.key_alt)
assert.is_nil(certificate["$refs"])
end)

it("generate correct cache key", function ()
local cache_key = db.vaults:cache_key("test")
assert.equal("vaults:test:::::", cache_key)
end)
end)
end

0 comments on commit 2732d15

Please sign in to comment.