perf(router/atc): move assert to unlikely path

Kong · Feb 26, 2024 · 0e91054 · 0e91054
1 parent 7e31f08
commit 0e91054
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/kong/router/fields.lua b/kong/router/fields.lua
@@ -197,8 +197,10 @@ else  -- stream
 end -- is_http
 
 
--- stream subsystem need not to generate func
-local get_field_accessor = function(funcs, field) end
+-- stream subsystem needs not to generate func
+local function get_field_accessor(funcs, field)
+  error("unknown router matching schema field: " .. field)
+end
 
 
 if is_http then
@@ -359,7 +361,8 @@ if is_http then
       return f
     end -- if field:sub(1, HTTP_SEGMENTS_PREFIX_LEN)
 
-    -- others return nil
+    -- others are error
+    error("unknown router matching schema field: " .. field)
   end
 
 end -- is_http
@@ -451,8 +454,6 @@ function _M:get_value(field, params, ctx)
   local func = FIELDS_FUNCS[field] or
                get_field_accessor(self.funcs, field)
 
-  assert(func, "unknown router matching schema field: " .. field)
-
   return func(params, ctx)
 end