Skip to content

Commit

Permalink
chore(ci): revert upload/download-artifact version bump to v4
Browse files Browse the repository at this point in the history
The v4 version causes issues in EE, so we decided to stay on v3 for now.

Reverts 9cf81ab
  • Loading branch information
hanshuebner authored and locao committed Jan 25, 2024
1 parent 6e1b466 commit 014f554
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ jobs:
luarocks config
- name: Bazel Outputs
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: failure()
with:
name: bazel-outputs
Expand Down
14 changes: 7 additions & 7 deletions .github/workflows/build_and_test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ jobs:
$TEST_CMD
- name: Archive coverage stats file
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }}
with:
name: luacov-stats-out-${{ github.job }}-${{ github.run_id }}
Expand Down Expand Up @@ -251,7 +251,7 @@ jobs:
- name: Download test rerun information
uses: actions/download-artifact@v4
uses: actions/download-artifact@v3
continue-on-error: true
with:
name: ${{ env.FAILED_TEST_FILES_FILE }}
Expand All @@ -273,14 +273,14 @@ jobs:
- name: Upload test rerun information
if: always()
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
with:
name: ${{ env.FAILED_TEST_FILES_FILE }}
path: ${{ env.FAILED_TEST_FILES_FILE }}
retention-days: 2

- name: Archive coverage stats file
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }}
with:
name: luacov-stats-out-${{ github.job }}-${{ github.run_id }}-${{ matrix.suite }}-${{ contains(matrix.split, 'first') && '1' || '2' }}
Expand Down Expand Up @@ -360,7 +360,7 @@ jobs:
.ci/run_tests.sh
- name: Archive coverage stats file
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }}
with:
name: luacov-stats-out-${{ github.job }}-${{ github.run_id }}
Expand Down Expand Up @@ -419,7 +419,7 @@ jobs:
.ci/run_tests.sh
- name: Archive coverage stats file
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: ${{ always() && (inputs.coverage == true || github.event_name == 'schedule') }}
with:
name: luacov-stats-out-${{ github.job }}-${{ github.run_id }}
Expand Down Expand Up @@ -449,7 +449,7 @@ jobs:
sudo luarocks install luafilesystem
# Download all archived coverage stats files
- uses: actions/download-artifact@v4
- uses: actions/download-artifact@v3

- name: Stats aggregation
shell: bash
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/perf.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ jobs:
luarocks
- name: Bazel Outputs
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: failure()
with:
name: bazel-outputs
Expand Down Expand Up @@ -267,7 +267,7 @@ jobs:
done
- name: Save results
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: always()
with:
name: perf-results
Expand All @@ -278,7 +278,7 @@ jobs:
retention-days: 31

- name: Save error logs
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v3
if: always()
with:
name: error_logs
Expand Down

0 comments on commit 014f554

Please sign in to comment.