chore(redis) enable ssl #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 1, 2022
Tieske
requested changes
Apr 1, 2022
There was a problem hiding this comment.
can we move the redis certs into a redis-subfolder; ./assets/redis ? similar to the expose and squid subfolders?
Also in the update, I think this line needs an update as well: https://github.com/Kong/kong-pongo/blob/master/assets/help/expose.txt#L15
Tieske
reviewed
Apr 1, 2022
Tieske
approved these changes
Apr 1, 2022
|
Thx @ADD-SP 👍 |
ADD-SP
added a commit
to Kong/kong
that referenced
this pull request
Apr 7, 2022
### Summary
This commit allows the SSL connection between the `rate-limiting` plugin and `Redis` to be tested.
### Full changelog
* Add relevant testing strategies to `spec/03-plugins/23-rate-limiting/05-integration_spec.lua`.
* Update `.github/workflows/build_and_test.yml` to enable SSL for Redis in CI
* Create folder `spec/fixtures/redis` and add the following files
* `ca.key`: Private key for the root certificate
* `ca.crt`: Root Certificate
* `server.key`: Private key for Redis server certificate
* `server.crt`: Redis server certificate
* `docker-entrypoint.sh`: To override the default
These certificates should be added to [Kong-Pongo](https://github.com/Kong/kong-pongo) and [gojira](https://github.com/Kong/gojira) to make it easy for developers to run tests locally.
Related PR: Kong/gojira#45, Kong/kong-pongo#270
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kong CE will soon be testing the SSL connection between the plugin and Redis, and we should upgrade Pongo to allow developers to run tests locally.
Also, we should ensure that both repositories use the same root certificate to issue certificates for the Redis server.
Related PR: Kong/kong#8662, Kong/gojira#45