Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: backwards compatibility for kalert #1484

Merged
merged 5 commits into from
Apr 15, 2024
Merged

fix: backwards compatibility for kalert #1484

merged 5 commits into from
Apr 15, 2024

Conversation

davidma415
Copy link
Contributor

@davidma415 davidma415 commented Apr 15, 2024

Summary

Need to add the alert-message prop for konnect-portal as that is not using kongponents alpha.

@davidma415 davidma415 marked this pull request as ready for review April 15, 2024 15:24
@davidma415 davidma415 requested a review from a team as a code owner April 15, 2024 15:24
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

non-blocking: might be worth putting a note in the PR that you're adding duplicate props to support host apps still using the old version of Kongponents (basically saying they shouldn't be removed)

@davidma415 davidma415 merged commit 4c9e648 into main Apr 15, 2024
5 checks passed
@davidma415 davidma415 deleted the chore/k-alerts branch April 15, 2024 16:20
kongponents-bot pushed a commit that referenced this pull request Apr 15, 2024
## [2.12.1](v2.12.0...v2.12.1) (2024-04-15)

### Bug Fixes

* backwards compatibility for kalert ([#1484](#1484)) ([4c9e648](4c9e648))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 2.12.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants