Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(style): remove usage of kongponents css custom props [KHCP-8877] #1324

Merged
merged 9 commits into from
Sep 13, 2023

Conversation

adamdehaven
Copy link
Member

@adamdehaven adamdehaven commented Sep 13, 2023

Summary

Remove the usage and import of the @kongponents-css-variables mixin.

Ready-To-Review Checklist

  • Tests: Includes any new/updated component tests
  • Docs: updates documentation as needed
  • Commit format/atomicity: the commits follow the guidelines outlined here

Ready-To-Merge Checklist

  • Reviewer - At least one reviewer has reviewed the following:
    • Functional: reviewed acceptance criteria and functionally tested the changes
    • Tests: Reviewer has checked the automated tests for correctness and completeness

Remove the usage and import of the kongponents css custom properties.
@adamdehaven adamdehaven self-assigned this Sep 13, 2023
@adamdehaven adamdehaven marked this pull request as ready for review September 13, 2023 16:56
@adamdehaven adamdehaven requested review from kongponents-bot and a team as code owners September 13, 2023 16:56
package.json Outdated
@@ -50,7 +50,7 @@
"@digitalroute/cz-conventional-changelog-for-jira": "^8.0.1",
"@evilmartians/lefthook": "^1.4.10",
"@kong/design-tokens": "^1.10.2",
"@kong/kongponents": "^8.123.6",
"@kong/kongponents": "^9.0.0-pr.1725.1d9bb913.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pointing to PR preview - is that intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not planning to merge yet - converting back to a draft 👍🏼

README.md Outdated Show resolved Hide resolved
@adamdehaven adamdehaven marked this pull request as draft September 13, 2023 17:46
@adamdehaven adamdehaven marked this pull request as ready for review September 13, 2023 17:51
Copy link
Member

@portikM portikM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@adamdehaven adamdehaven merged commit 65adf7b into main Sep 13, 2023
4 checks passed
@adamdehaven adamdehaven deleted the feat/remove-kongponents-variables branch September 13, 2023 18:20
kongponents-bot pushed a commit that referenced this pull request Sep 13, 2023
# [2.10.0](v2.9.0...v2.10.0) (2023-09-13)

### Features

* **style:** remove usage of kongponents css custom props [KHCP-8877] ([#1324](#1324)) ([65adf7b](65adf7b))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 2.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants