-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed docker container issue and added docker-compose file to simplify config #70
Closed
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
ce5021e
Removed dockerfile, added docker-compose and run.sh to install Promis…
f29a70e
Updated docker installation docs
d651c42
Added env variable to docker-compose to set redis and updated run.sh
bda9827
removed commented line in run.sh
3b6d5f8
new line at end of file for run.sh
b51c747
Fixing formatting issues
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,25 @@ | ||
version: '2' | ||
|
||
services: | ||
|
||
redis: | ||
container_name: mockbinredis | ||
image: redis | ||
ports: | ||
- "6379:6379" | ||
|
||
mockbin: | ||
image: "node:8" | ||
user: "node" | ||
working_dir: /home/node/app | ||
volumes: | ||
- ./:/home/node/app | ||
expose: | ||
- "8080" | ||
ports: | ||
- "8099:8080" | ||
command: "bash run.sh" | ||
links: | ||
- "redis:mockbinredis" | ||
environment: | ||
MOCKBIN_REDIS: redis://mockbinredis:6379 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
npm install | ||
npm install es6-promise | ||
npm start |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO it would be better to add this to
package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought of that but this would affect the application itself. I couldn't see any issue regarding using installable application (without docker) so thought it could be an issue with docker setup (like missing some libs in setup).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding
es6-promise
resolved #62 because it is a dependency of this app from what I can tell. Annpm install mockbin
on a blank system yields the same error as the Docker build