Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): more country flags #320

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

mihai-peteu
Copy link
Contributor

@mihai-peteu mihai-peteu commented Jun 6, 2024

Summary

Spoke to @tilton after realizing I was missing quite a few country flags. This should be the last big batch of additions 😬
Preview locally with yarn install --frozen-lockfile && yarn preview:sandbox

Note to self - must run yarn test -u to create snapshots.

adamdehaven
adamdehaven previously approved these changes Jun 6, 2024
@adamdehaven adamdehaven dismissed their stale review June 7, 2024 00:19

So many flags

Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are ~195 countries in the world. Why do we have so many more flags?

@adamdehaven adamdehaven merged commit 7de2c9c into main Jun 7, 2024
4 checks passed
@adamdehaven adamdehaven deleted the feat/add-remaining-country-icons branch June 7, 2024 21:20
kongponents-bot pushed a commit that referenced this pull request Jun 7, 2024
# [1.13.0](v1.12.2...v1.13.0) (2024-06-07)

### Features

* **flags:** more country flags ([#320](#320)) ([7de2c9c](7de2c9c))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@kongponents-bot
Copy link
Collaborator

Install the preview package from this PR in your consuming application

In your host project, you may install the preview package version generated by this PR:

yarn add @kong/icons@pr-320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants