Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add icons for analytics teams [MA-2243] #133

Merged
merged 3 commits into from
Nov 6, 2023
Merged

feat: add icons for analytics teams [MA-2243] #133

merged 3 commits into from
Nov 6, 2023

Conversation

two24studios
Copy link
Collaborator

@two24studios two24studios commented Nov 6, 2023 •
edited
Loading

Summary

Added bar-chart-horizontal, chart-area, and chart-lines

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@adamdehaven adamdehaven changed the title New icons for analytics teams New icons for analytics teams [MA-2243] Nov 6, 2023
@adamdehaven adamdehaven changed the title New icons for analytics teams [MA-2243] feat: add icons for analytics teams [MA-2243] Nov 6, 2023
adamdehaven
adamdehaven approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adamdehaven adamdehaven enabled auto-merge (squash) November 6, 2023 20:00
@adamdehaven adamdehaven disabled auto-merge November 6, 2023 20:00
@adamdehaven adamdehaven merged commit 70c3194 into main Nov 6, 2023
3 checks passed
@adamdehaven adamdehaven deleted the new-icons-nov23 branch November 6, 2023 20:00
kongponents-bot pushed a commit that referenced this pull request Nov 6, 2023
@semantic-release-bot
chore(release): 1.8.0 [skip ci]
3cbd2f2 
# [1.8.0](v1.7.8...v1.8.0) (2023-11-06)

### Features

* add icons for analytics teams [MA-2243] ([#133](#133)) ([70c3194](70c3194))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

@portikM portikM Awaiting requested review from portikM portikM is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@two24studios @kongponents-bot @adamdehaven