Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add new icons and update workspaces icon #105

Merged
merged 1 commit into from
Oct 17, 2023
Merged

fix: add new icons and update workspaces icon #105

merged 1 commit into from
Oct 17, 2023

Conversation

two24studios
Copy link
Collaborator

Summary

Added:

  • cog-mode
  • equal
  • rocket

Updated:

  • workspaces

PR Checklist

  • Does not introduce dependencies
  • Functional: all changes do not break existing APIs and if so, bump major version.
  • Tests pass: check the output of yarn test
  • Naming: the files and the method and prop variables use the same naming conventions as other Kongponents
  • Framework style: abides by the essential rules in Vue's style guide
  • Cleanliness: does not have formatting issues, unused code (e.g., console.logs, debugger), or leftover comments
  • Docs: includes a technically accurate README, uses JSDOC where appropriate

@two24studios two24studios requested review from a team, adamdehaven and jillztom as code owners October 17, 2023 18:53
@two24studios two24studios self-assigned this Oct 17, 2023
adamdehaven
adamdehaven approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@adamdehaven adamdehaven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@CLAassistant
Copy link

CLAassistant commented Oct 17, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@adamdehaven adamdehaven merged commit fefea07 into main Oct 17, 2023
3 checks passed
@adamdehaven adamdehaven deleted the new-icons-oct23 branch October 17, 2023 20:04
kongponents-bot pushed a commit that referenced this pull request Oct 17, 2023
@semantic-release-bot
chore(release): 1.7.4 [skip ci]
83f3811 
## [1.7.4](v1.7.3...v1.7.4) (2023-10-17)

### Bug Fixes

* add new icons and update workspaces icon ([#105](#105)) ([fefea07](fefea07))
@kongponents-bot
Copy link
Collaborator

🎉 This PR is included in version 1.7.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamdehaven adamdehaven adamdehaven approved these changes

@jillztom jillztom Awaiting requested review from jillztom jillztom is a code owner

Assignees

@two24studios two24studios

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@two24studios @CLAassistant @kongponents-bot @adamdehaven