Skip to content

Commit

Permalink
fix: update notification icon (#437)
Browse files Browse the repository at this point in the history
  • Loading branch information
portikM authored Nov 7, 2024
1 parent a8d0b40 commit e7868a9
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/publish.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
# against for future runs. Since the snapshot files are modified here in the CI, they are written back
# to the repository via the `/package.json` file `@semantic-release/git` => `assets` config
- name: Update test snapshots
run: pnpm test -u
run: pnpm test -- --update

- name: Semantic Release
uses: cycjimmy/semantic-release-action@v4
Expand Down
6 changes: 3 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ To add a new SVG:
2. Ensure the filename is lowercase and kebab-case
3. Place the SVG file into the corresponding `/svg/*` subdirectory.
4. Locally, run `pnpm generate` to create the corresponding Vue component
5. Locally, run `pnpm test -- -u` to run the tests and update the test snapshots
5. Locally, run `pnpm test -- --update` to run the tests and update the test snapshots
6. [Commit your changes](#committing-changes) and push up a Pull Request for review

### Development Sandbox
Expand Down Expand Up @@ -193,10 +193,10 @@ pnpm test
pnpm test:open

# Update test snapshots
pnpm test -u
pnpm test -- --update
```

When SVG files are added or removed, this will cause the test(s) that compare snapshots to fail. If the snapshot change is expected, run `pnpm test -u` to update the test snapshots accordingly, then commit those changes to your branch.
When SVG files are added or removed, this will cause the test(s) that compare snapshots to fail. If the snapshot change is expected, run `pnpm test -- --update` to update the test snapshots accordingly, then commit those changes to your branch.

### Build for production

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,7 @@ exports[`generate > does not remove icons from the previous build 1`] = `
"FlagZwIcon.vue",
"ForwardIcon.vue",
"GatewayIcon.vue",
"GithubIcon.vue",
"GoogleCloudIcon.vue",
"GoogleIcon.vue",
"GraduationIcon.vue",
Expand Down
2 changes: 1 addition & 1 deletion src/tests/__snapshots__/NotificationIcon.html
Original file line number Diff line number Diff line change
@@ -1 +1 @@
<span class="kui-icon notification-icon" data-testid="kui-icon-wrapper-notification-icon" style="box-sizing: border-box; color: rgb(0, 68, 244); display: inline-flex; flex-shrink: 0; height: 32px; line-height: 0; width: 32px;"><svg data-testid="kui-icon-svg-notification-icon" fill="none" height="100%" role="img" viewBox="0 0 24 24" width="100%" xmlns="http://www.w3.org/2000/svg"><title data-testid="kui-icon-svg-title">My custom title</title><path d="M4 19V17H6V10C6 8.61667 6.41667 7.3875 7.25 6.3125C8.08333 5.2375 9.16667 4.53333 10.5 4.2V3.5C10.5 3.08333 10.6458 2.72917 10.9375 2.4375C11.2292 2.14583 11.5833 2 12 2C12.4167 2 12.7708 2.14583 13.0625 2.4375C13.3542 2.72917 13.5 3.08333 13.5 3.5V4.2C14.8333 4.53333 15.9167 5.2375 16.75 6.3125C17.5833 7.3875 18 8.61667 18 10V17H20V19H4ZM12 22C11.45 22 10.9792 21.8042 10.5875 21.4125C10.1958 21.0208 10 20.55 10 20H14C14 20.55 13.8042 21.0208 13.4125 21.4125C13.0208 21.8042 12.55 22 12 22ZM8 17H16V10C16 8.9 15.6083 7.95833 14.825 7.175C14.0417 6.39167 13.1 6 12 6C10.9 6 9.95833 6.39167 9.175 7.175C8.39167 7.95833 8 8.9 8 10V17Z" fill="currentColor"></path></svg></span>
<span class="kui-icon notification-icon" data-testid="kui-icon-wrapper-notification-icon" style="box-sizing: border-box; color: rgb(0, 68, 244); display: inline-flex; flex-shrink: 0; height: 32px; line-height: 0; width: 32px;"><svg data-testid="kui-icon-svg-notification-icon" fill="none" height="100%" role="img" viewBox="0 0 24 24" width="100%" xmlns="http://www.w3.org/2000/svg"><title data-testid="kui-icon-svg-title">My custom title</title><path d="M5 19C4.71667 19 4.47917 18.9042 4.2875 18.7125C4.09583 18.5208 4 18.2833 4 18C4 17.7167 4.09583 17.4792 4.2875 17.2875C4.47917 17.0958 4.71667 17 5 17H6V10C6 8.61667 6.41667 7.3875 7.25 6.3125C8.08333 5.2375 9.16667 4.53333 10.5 4.2V3.5C10.5 3.08333 10.6458 2.72917 10.9375 2.4375C11.2292 2.14583 11.5833 2 12 2C12.4167 2 12.7708 2.14583 13.0625 2.4375C13.3542 2.72917 13.5 3.08333 13.5 3.5V4.2C14.8333 4.53333 15.9167 5.2375 16.75 6.3125C17.5833 7.3875 18 8.61667 18 10V17H19C19.2833 17 19.5208 17.0958 19.7125 17.2875C19.9042 17.4792 20 17.7167 20 18C20 18.2833 19.9042 18.5208 19.7125 18.7125C19.5208 18.9042 19.2833 19 19 19H5ZM12 22C11.45 22 10.9792 21.8042 10.5875 21.4125C10.1958 21.0208 10 20.55 10 20H14C14 20.55 13.8042 21.0208 13.4125 21.4125C13.0208 21.8042 12.55 22 12 22Z" fill="currentColor"></path></svg></span>
2 changes: 1 addition & 1 deletion svg/solid/notification.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit e7868a9

Please sign in to comment.