fix(pluginsocket.proto): type for set_upstream
#191
Merged
+85
−85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gszr
force-pushed
the
fix/setupstream-return
branch
from
fadc683 to
c5f5348
Compare
|
Tests failure expected until Kong PR is merged. |
gszr
added a commit
to Kong/kong
that referenced
this pull request
Mar 12, 2024
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue Kong/go-pdk#114. Sister PR: Kong/go-pdk#191
nowNick
approved these changes
Mar 13, 2024
flrgh
approved these changes
Mar 13, 2024
gszr
added a commit
to Kong/kong
that referenced
this pull request
Mar 13, 2024
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue Kong/go-pdk#114. Sister PR: Kong/go-pdk#191
gszr
force-pushed
the
fix/setupstream-return
branch
from
c5f5348 to
3f8ca70
Compare
Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue #114. Sister PR: Kong/kong#12727
gszr
force-pushed
the
fix/setupstream-return
branch
from
3f8ca70 to
cbac0ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the return type for the
.Service.SetUpstreamexternal plugin PDK method.Fixes issue #114.
Sister PR: Kong/kong#12727